Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio engine v2 #15839

Draft
wants to merge 250 commits into
base: master
Choose a base branch
from
Draft

Add audio engine v2 #15839

wants to merge 250 commits into from

Conversation

docEdub
Copy link
Contributor

@docEdub docEdub commented Nov 18, 2024

This change adds the initial audio engine v2 implementation and introduces the API for sound and streaming sound creation and playback, in addition to audio buses (formerly known as SoundTracks).

This change adds the initial audio engine v2 implementation and introduces the API for sound and streaming sound creation and playback.
This change gets the CI's `Test UMD build` step to pass.
@ryantrem
Copy link
Member

Am I remembering correctly from previous conversations that the new audio engine will implement the existing interfaces, or no?

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 18, 2024

@docEdub
Copy link
Contributor Author

docEdub commented Nov 18, 2024

Am I remembering correctly from previous conversations that the new audio engine will implement the existing interfaces, or no?

Yes, this is something we discussed as a possibility.

If not given, the `engine` defaults to the last created engine.
A document body is required for the underlying HTMLMediaElement used in `WebAudioStreaminSoundInstance`.
When a streaming instance is paused before it transitions from `Starting` to `Started`, the start offset is being set incorrectly when resumed. This change fixes the issue by setting the related timing variables correctly and initializing the start time to `Infinity` to indicate that the instance has not actually started, yet.
This change makes the playground intellisense list the valid types instead of hiding them behind a single custom type.
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Feb 7, 2025
@bjsplat

This comment was marked as duplicate.

@bjsplat

This comment was marked as duplicate.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants