Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use same configuration between DracoCompression and DracoDecoder #16070

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Use same configuration between DracoCompression and DracoDecoder #16070

merged 4 commits into from
Jan 16, 2025

Conversation

alexchuber
Copy link
Contributor

@alexchuber alexchuber commented Jan 15, 2025 •
edited
Loading

Rather than maintain a separate copy of a configuration for DracoCompression, reference DracoEncoder's instead.
See https://forum.babylonjs.com/t/babylon-draco-url-config-not-working/55741/9

Example test: #2WHRHL#1

@alexchuber alexchuber requested a review from bghgary January 15, 2025 22:54
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 15, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 15, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 15, 2025

Snapshot stored with reference name:
refs/pull/16070/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16070/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16070/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16070/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16070/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16070/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16070/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16070/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 15, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16070/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 15, 2025

Visualization tests for WebGPU (Experimental)

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16070/merge/testResults/webgpuplaywright/index.html

@alexchuber alexchuber added bug and removed bug labels Jan 16, 2025
@alexchuber alexchuber merged commit de641c0 into BabylonJS:master Jan 16, 2025
14 checks passed
@alexchuber alexchuber deleted the draco-compression-fix branch February 7, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bghgary bghgary bghgary approved these changes

Assignees
No one assigned
Labels
skip changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexchuber @bjsplat @bghgary