Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ScreenshotTools #16081

Merged
merged 12 commits into from
Jan 17, 2025
Merged

Fix ScreenshotTools #16081

merged 12 commits into from
Jan 17, 2025

Conversation

sebavan
Copy link
Member

@sebavan sebavan commented Jan 16, 2025

No description provided.

sebavan added 12 commits December 20, 2024 00:12
@sebavan
Fix oneffecterrorobs
bcf0df4
@sebavan
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
933b3af 
… work2
@sebavan
Fix NormalMaterial with ThinInstances
8d4b10b
@sebavan
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
d1efba5 
… work2
@sebavan
Fix Animation loop in CreateAndStartAnimation
3c7e5ca
@sebavan
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
ee72813 
… work2
@sebavan
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
73cef30 
… work2
@sebavan
Fix lineMesh cloned alpha values
b2d0417
@sebavan
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
4f999ab 
… work2
@sebavan
Fix recursive loop in onPointerOutAction
475c282
@sebavan
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
b518fdf 
… work2
@sebavan
Fix ScreenshotTools
89508b8
@sebavan sebavan added the bug label Jan 16, 2025
@sebavan sebavan requested review from deltakosh and Popov72 January 16, 2025 23:54
@sebavan sebavan enabled auto-merge (squash) January 16, 2025 23:54
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 16, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 17, 2025

Snapshot stored with reference name:
refs/pull/16081/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16081/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16081/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16081/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16081/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16081/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16081/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16081/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 17, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16081/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 17, 2025

Visualization tests for WebGPU (Experimental)

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16081/merge/testResults/webgpuplaywright/index.html

@sebavan sebavan merged commit d1c9b3b into BabylonJS:master Jan 17, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

@Popov72 Popov72 Awaiting requested review from Popov72

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebavan @bjsplat @deltakosh