Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local resources when developing #16083

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jan 17, 2025

When using the local server or a snapshot/version on the playground the async-loaded resources are still downloaded from the cdn instead of the local directory.

For example, opening this:

https://playground.babylonjs.com/?version=6.0.0#4RN0VF

Will load the 6.0.0 CDN resources, but the basis loader will still be downloaded from the main CDN. Same thing goes to local development.

This PR changes that - when developing locally you will get the locally-hosted resources. Same thing for snapshots and versioned URLs.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 17, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 17, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16083/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16083/merge/?snapshot=refs/pull/16083/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 17, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16083/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 17, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 17, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 17, 2025

@RaananW RaananW merged commit a0f9ab8 into BabylonJS:master Jan 17, 2025
16 checks passed
@RaananW RaananW deleted the useLocalResources branch January 20, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants