reset ideal width and height on serialization #16084
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16084/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16084/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16084/merge#BCU1XR#0 |
|
Visualization tests for WebGPU (Experimental) |
|
WebGL2 visualization test reporter: |
When closning an element in an ADT (i.e. a GUI element), the ideal width andd ideal height of its host influence the data serialized.
I consider this a bug on our end - serialized data should not be influenced by the object's parent.
This PR resets the ideal width and height of the ADT host when cloning an element.
There is an interesting "breaking change" here, but it is far fetched and probably not really used:
When cloning from one ADT to another, it is possible that the element will not have different size, if both ADTs have a different idealWidth or idealHeight.
However, as this can be considered a bug fix, the new behavior is the right one, so I don't see that as a problem nor as a breaking change.
PG to test: #KKA6L4#20
Forum post that triggered it:
https://forum.babylonjs.com/t/gui-control-clone-doesnt-respect-ideal-width/55494?u=raananw