Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding assets loading URLs in core #16089

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Allow overriding assets loading URLs in core #16089

merged 2 commits into from
Jan 20, 2025

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jan 20, 2025

Directly related to this:

BabylonJS/Assets#89

This allows a developer to avoid using our assets library and define their own URL for loading assets.
All assets referenced will be in the /core directory in the Assets repository.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 20, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 20, 2025

Snapshot stored with reference name:
refs/pull/16089/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16089/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16089/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16089/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16089/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16089/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16089/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16089/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 20, 2025

Visualization tests for WebGPU (Experimental)

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16089/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 20, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16089/merge/testResults/webgl2playwright/index.html

@RaananW
Copy link
Member Author

RaananW commented Jan 20, 2025

Tests are failing because the assets are not yet available in their new location.

sebavan
sebavan approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !!!

@RaananW RaananW merged commit 16c50c3 into BabylonJS:master Jan 20, 2025
14 checks passed
@RaananW RaananW deleted the assetsBaseURL branch January 20, 2025 20:17
@RaananW RaananW mentioned this pull request Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RaananW @bjsplat @sebavan