Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix race condition with meshopt compression #16091

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jan 21, 2025

In certain (rare, one must say) cases, the calll to useWorkers(0) makes the meshopt not work correctly and not return the mesh even after the work is done.

This adds a kind of debounce to setting the workers number back to 0.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 21, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@RaananW RaananW added the bug label Jan 21, 2025
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 21, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 21, 2025

@sebavan sebavan merged commit 4b424cc into BabylonJS:master Jan 21, 2025
14 checks passed
@RaananW RaananW deleted the useWorkerThrottle branch January 21, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants