Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DepthRenderer: fix effect cache #16092

Merged
merged 1 commit into from
Jan 22, 2025
Merged

DepthRenderer: fix effect cache #16092

merged 1 commit into from
Jan 22, 2025

Conversation

kzhsw
Copy link
Contributor

@kzhsw kzhsw commented Jan 22, 2025

This commit fixed the defines prop in drawWrapper so that the effect cache would work as expected.

Forum link: https://forum.babylonjs.com/t/depthrenderer-effect-not-cached/56092

This commit fixed the `defines` prop in `drawWrapper` so that the effect cache would work as expected.

Forum link: <https://forum.babylonjs.com/t/depthrenderer-effect-not-cached/56092>
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 22, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 22, 2025

@sebavan sebavan enabled auto-merge (squash) January 22, 2025 00:52
@sebavan sebavan merged commit b38c9b5 into BabylonJS:master Jan 22, 2025
14 checks passed
@kzhsw kzhsw deleted the patch-1 branch January 22, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants