Add AbortError and use in Viewer #16097
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16097/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16097/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16097/merge#BCU1XR#0 |
|
Visualization tests for WebGPU (Experimental) |
|
WebGL2 visualization test reporter: |
There was some feedback from users that it was confusing to see abort/cancellation errors in the log, since it seemed to indicate something bad was happening when in reality it wasn't. It was simply that a new model or environment was being loaded before the previous one finished loading. This change introduces an
AbortError(there isn't a standard as part of WebAPI), uses it in theAbortController.abortcalls, and checks for it in theViewerElementso we can ignore abort/cancellation errors (but still log "real" errors).@alexandremottet, @cournoll