New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing environment change event #16101

Merged

sebavan merged 2 commits into BabylonJS:master from alexandremottet:add-missing-environment-change-event

Jan 23, 2025

Contributor

alexandremottet commented Jan 23, 2025

Writting down to documentation for the new environment properties, I realise that :

no event was triggerred by the ViewerElement when the environment configuration change
some comments still mentionning degrees for the enviornment rotation

alexandremottet added 2 commits

January 23, 2025 10:22


          add missing environment configuration change event

102beb2


          fix wrong rotation unit from degrees to radians in comment

a3e7337

Collaborator

bjsplat commented Jan 23, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Collaborator

bjsplat commented Jan 23, 2025

Snapshot stored with reference name:
refs/pull/16101/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16101/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16101/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16101/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16101/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16101/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16101/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16101/merge#BCU1XR#0

Collaborator

bjsplat commented Jan 23, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16101/merge/testResults/webgl2playwright/index.html

Collaborator

bjsplat commented Jan 23, 2025

Visualization tests for WebGPU (Experimental)

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16101/merge/testResults/webgpuplaywright/index.html

RaananW requested a review from ryantrem

January 23, 2025 10:28

sebavan approved these changes

View reviewed changes

sebavan merged commit f2a7eab into BabylonJS:master

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet