Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TypedArray utilities #16109

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Move TypedArray utilities #16109

merged 6 commits into from
Jan 28, 2025

Conversation

alexchuber
Copy link
Contributor

Move TypedArray utilities to common buffer utility file. Replace TypedArray with TypedArrayLike in core types.

@alexchuber alexchuber requested a review from bghgary January 24, 2025 22:47
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 24, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 24, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16109/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 24, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16109/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 25, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16109/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 25, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16109/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16109/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16109/merge/testResults/webgl2playwright/index.html

@ryantrem
Copy link
Member

ryantrem commented Jan 27, 2025 •
edited
Loading

Replace TypedArray with TypedArrayLike in core types.

Was this part of an older itereation of the PR?

@alexchuber
Copy link
Contributor Author

alexchuber commented Jan 27, 2025 •
edited
Loading

Replace TypedArray with TypedArrayLike in core types.

Yes, this commit was from an older iteration of the PR. I first wanted to replace TypedArray with TypedArrayLike, then realized I preferred the TypedArray over TypedArrayLike, and undid it. (Using the union of all TypedArrays allows us to access its utility functions like .every(), .slice(), etc. without adding them to the interface.)

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16109/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16109/merge/testResults/webgpuplaywright/index.html

@sebavan sebavan enabled auto-merge (squash) January 28, 2025 17:12
@sebavan sebavan merged commit 28fa2b4 into BabylonJS:master Jan 28, 2025
14 checks passed
@alexchuber alexchuber mentioned this pull request Jan 28, 2025
Merged
@alexchuber alexchuber deleted the typed-array-utils branch February 7, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantrem ryantrem ryantrem left review comments

@bghgary bghgary bghgary left review comments

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
skip changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexchuber @bjsplat @ryantrem @sebavan @bghgary