Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading screen multiple canvases #16112

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Fix loading screen multiple canvases #16112

merged 5 commits into from
Jan 28, 2025

Conversation

simonedevit
Copy link
Contributor

@simonedevit simonedevit commented Jan 27, 2025 •
edited
Loading

The following PR fixes the loading screen on multiple canvases.

Forum link: https://forum.babylonjs.com/t/loading-screen-misplaced-on-multiple-canvases/56234.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Snapshot stored with reference name:
refs/pull/16112/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16112/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16112/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16112/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16112/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16112/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16112/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16112/merge#BCU1XR#0

deltakosh
deltakosh approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@deltakosh deltakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat! thanks a ton for that contrib!

@deltakosh deltakosh requested a review from RaananW January 27, 2025 16:53
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16112/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16112/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16112/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16112/merge/testResults/webgpuplaywright/index.html

@deltakosh deltakosh enabled auto-merge (squash) January 27, 2025 21:49
@deltakosh deltakosh merged commit d091b79 into BabylonJS:master Jan 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

@RaananW RaananW RaananW approved these changes

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simonedevit @bjsplat @deltakosh @RaananW @sebavan