Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coloured IBL shadows #16113

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Coloured IBL shadows #16113

merged 2 commits into from
Jan 28, 2025

Conversation

MiiBond
Copy link
Contributor

@MiiBond MiiBond commented Jan 27, 2025

This PR adds a toggle to the IBL Render Pipeline to enable coloured shadow rendering. It requires more texture samples during voxel tracing but produces more accurate results. Defaults to off.
1
B W2

https://playground.babylonjs.com/#8R5SSE#497

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Snapshot stored with reference name:
refs/pull/16113/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16113/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16113/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16113/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16113/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16113/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16113/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16113/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16113/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16113/merge/testResults/webgl2playwright/index.html

@sebavan sebavan requested a review from Popov72 January 27, 2025 22:05
@sebavan sebavan merged commit f251269 into BabylonJS:master Jan 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

@Popov72 Popov72 Popov72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MiiBond @bjsplat @Popov72 @sebavan