Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Editors: Fix wrong properties displayed in node editors #16114

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Jan 27, 2025

instance.constructor.name doesn't work with minified packages, so I used instance.constructor.getClassName() instead, as all the classes involved implement a getClassName method.

@Popov72 Popov72 added bug nme Node Material Editor nge nrge node render graph editor labels Jan 27, 2025
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16114/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16114/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16114/merge/?snapshot=refs/pull/16114/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@deltakosh deltakosh enabled auto-merge (squash) January 27, 2025 21:48
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

@deltakosh deltakosh merged commit 13ac61f into BabylonJS:master Jan 27, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug nge nme Node Material Editor nrge node render graph editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants