Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer: fix camera-orbit and camera-target attributes #16116

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

ryantrem
Copy link
Member

With a recent refactoring, I accidentally broke camera-orbit and camera-target. This happened because the order of operations slightly changed, and so it became:

  1. Load the model
  2. Fire the observable
  3. Element sets the camera-orbit and camera-target
  4. Set the default animation, which implicitly resets the camera (therefore discarding the camera-orbit and camera-target)

This PR both fixes this problem, and introduces some new Playwright automated tests. The initial set of tests validate these recent regressions, but I will continue to flesh out the tests.

@RaananW - what else is needed to have these tests run in the CI?

@ryantrem ryantrem requested a review from RaananW January 27, 2025 23:57
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 28, 2025

@ryantrem ryantrem requested a review from sebavan January 28, 2025 00:12
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 28, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 28, 2025

@sebavan sebavan merged commit cbe8bad into BabylonJS:master Jan 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants