Viewer: fix camera-orbit and camera-target attributes #16116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a recent refactoring, I accidentally broke
camera-orbit
andcamera-target
. This happened because the order of operations slightly changed, and so it became:This PR both fixes this problem, and introduces some new Playwright automated tests. The initial set of tests validate these recent regressions, but I will continue to flesh out the tests.
@RaananW - what else is needed to have these tests run in the CI?