Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading screen when the scrollbar is present #16127

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fix loading screen when the scrollbar is present #16127

merged 1 commit into from
Jan 30, 2025

Conversation

simonedevit
Copy link
Contributor

The following PR fixes the loading screen when the scrollbar is present and already scrolled.

Forum link: https://forum.babylonjs.com/t/loading-screen-misplaced-on-multiple-canvases/56234/4.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 30, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 30, 2025

Snapshot stored with reference name:
refs/pull/16127/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16127/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16127/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16127/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16127/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16127/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16127/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16127/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 30, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16127/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 30, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16127/merge/testResults/webgl2playwright/index.html

deltakosh
deltakosh approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@deltakosh deltakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deltakosh deltakosh merged commit e55c717 into BabylonJS:master Jan 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonedevit @bjsplat @deltakosh