Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set return type to avoid generics #16129

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jan 30, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 30, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 30, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 30, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 30, 2025

@sebavan
Copy link
Member

sebavan commented Jan 30, 2025

@RaananW, I wonder if you need to pull master in as the sync compilation test is failing in here

@RaananW RaananW enabled auto-merge (squash) January 30, 2025 19:55
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 30, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 30, 2025

@RaananW RaananW merged commit 15eb68a into BabylonJS:master Jan 30, 2025
14 of 15 checks passed
@RaananW RaananW deleted the defineReturnTypeToAvoidTSNonsense branch January 30, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants