Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feedback loop rendering that was writing to the depth buffer #16134

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Fix feedback loop rendering that was writing to the depth buffer #16134

merged 1 commit into from
Jan 31, 2025

Conversation

deltakosh
Copy link
Contributor

No description provided.

@deltakosh deltakosh added the bug label Jan 31, 2025
@deltakosh deltakosh enabled auto-merge (squash) January 31, 2025 18:07
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 31, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 31, 2025

Snapshot stored with reference name:
refs/pull/16134/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16134/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16134/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16134/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16134/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16134/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16134/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16134/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 31, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16134/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 31, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16134/merge/testResults/webgl2playwright/index.html

@deltakosh deltakosh changed the title Fix feedback loop rendered that was rendering to the depth buffer Fix feedback loop rendering that was writing to the depth buffer Jan 31, 2025
@deltakosh deltakosh disabled auto-merge January 31, 2025 19:45
@deltakosh deltakosh merged commit aa084ca into master Jan 31, 2025
15 checks passed
@deltakosh deltakosh deleted the fix-gpu-parts branch January 31, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deltakosh @bjsplat