Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing conversion #16139

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Fix missing conversion #16139

merged 1 commit into from
Feb 3, 2025

Conversation

deltakosh
Copy link
Contributor

No description provided.

@deltakosh deltakosh added the bug label Feb 3, 2025
@deltakosh deltakosh enabled auto-merge (squash) February 3, 2025 20:11
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 3, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

sebavan
sebavan approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how it went through

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 3, 2025

Snapshot stored with reference name:
refs/pull/16139/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16139/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16139/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16139/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16139/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16139/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16139/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16139/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 3, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16139/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 3, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16139/merge/testResults/webgpuplaywright/index.html

@deltakosh deltakosh merged commit 50cff1c into master Feb 3, 2025
14 of 15 checks passed
@deltakosh deltakosh deleted the fix-part-webgpu branch February 3, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deltakosh @bjsplat @sebavan