Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure an engine with exception is cleared #16151

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Make sure an engine with exception is cleared #16151

merged 1 commit into from
Feb 6, 2025

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Feb 6, 2025 •
edited
Loading

See https://forum.babylonjs.com/t/safari-mac-bug-glb-fails-to-load-after-create-screenshot-using-render-target/56381/12?u=raananw

As a side note, to test this I forced-threw an exception during engine construction (of course not commited :-) )

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 6, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 6, 2025

Snapshot stored with reference name:
refs/pull/16151/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16151/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16151/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16151/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16151/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16151/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16151/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16151/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 6, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16151/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 6, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16151/merge/testResults/webgpuplaywright/index.html

@deltakosh deltakosh merged commit 8006d50 into BabylonJS:master Feb 6, 2025
15 checks passed
@RaananW RaananW deleted the dumpToolsBugFix branch February 6, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RaananW @bjsplat @deltakosh