Viewer: Add removeEventListener typings #16155
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16155/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16155/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16155/merge#BCU1XR#0 |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
Previously I had added strong typing for
addEventListenerfor theViewerElement's custom events, but I forgot to do the same forremoveEventListener. In this PR, I am addingremoveEventListener, but I'm also moving this to be type only. Previously I did this typing by overriding the baseaddEventListenerand calling it onsuper, but there is nothing actually needed at runtime for this, so we may as well remove any runtime impact (one extra frame on the callstack, a tiny bit of extra code in the final bundle).