Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pointerId leak when a pen is lifted off the digitizer #16156

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

AmoebaChant
Copy link
Contributor

When a pen is lifted off the digitizer, beyond the range of the digitizer to detect it, the pointerleave event is raised. This fix listens to that event, and the pointer is a pen, it calls into the existing logic to cancel a touch operation.

This addresses the issue reported here in the forum: https://forum.babylonjs.com/t/onpointerobservable-ignoring-tablet-pen-input/56405

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@AmoebaChant AmoebaChant added the bug label Feb 7, 2025
Copy link
Contributor

@deltakosh deltakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@deltakosh deltakosh enabled auto-merge (squash) February 7, 2025 01:25
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2025

@deltakosh deltakosh merged commit 7aedc45 into BabylonJS:master Feb 7, 2025
13 of 15 checks passed
@AmoebaChant AmoebaChant deleted the fix-pen-lift-leak branch February 7, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants