Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NativeEngine captureGPUFrameTime + getGPUFrameTimeCounter #16159

Merged
merged 3 commits into from
Feb 8, 2025
Merged

NativeEngine captureGPUFrameTime + getGPUFrameTimeCounter #16159

merged 3 commits into from
Feb 8, 2025
+37 −2

Conversation

ryantrem
Copy link
Member

@ryantrem ryantrem commented Feb 7, 2025 •
edited
Loading

This change overrides startTimeQuery and endTimeQuery in NativeEngine such that captureGPUFrameTime and getGPUFrameTimeCounter work. They do so by calling the new populateFrameStats function on the native side of NativeEngine.
Corresponding BN change: BabylonJS/BabylonNative#1458

@ryantrem ryantrem mentioned this pull request Feb 7, 2025
Open
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@ryantrem ryantrem requested review from bghgary and sebavan February 7, 2025 22:08
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2025

Snapshot stored with reference name:
refs/pull/16159/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16159/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16159/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16159/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16159/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16159/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16159/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16159/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16159/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16159/merge/testResults/webgl2playwright/index.html

bghgary
bghgary approved these changes Feb 7, 2025
View reviewed changes
packages/dev/core/src/Engines/nativeEngine.ts Outdated Show resolved Hide resolved
@sebavan sebavan enabled auto-merge (squash) February 7, 2025 23:54
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 8, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16159/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 8, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16159/merge/testResults/webgpuplaywright/index.html

@sebavan sebavan merged commit 4d9cbe5 into BabylonJS:master Feb 8, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

@bghgary bghgary bghgary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryantrem @bjsplat @sebavan @bghgary