Add Irradiance texture support in Env format (#16149)

* move timer stats to thinEngine * fix case * PR Feedback * Add Irradiance texture support in Env format
BabylonJS · Feb 6, 2025 · 817f98e · 817f98e
1 parent 8006d50
commit 817f98e
Show file tree

Hide file tree

Showing 5 changed files with 331 additions and 107 deletions.
diff --git a/packages/dev/core/src/Engines/Extensions/engine.rawTexture.ts b/packages/dev/core/src/Engines/Extensions/engine.rawTexture.ts
@@ -476,6 +476,11 @@ ThinEngine.prototype.createRawCubeTextureFromUrl = function (
     };
 
     const internalCallback = (data: any) => {
+        // If the texture has been disposed
+        if (!texture._hardwareTexture) {
+            return;
+        }
+
         const width = texture.width;
         const faceDataArrays = callback(data);
 

diff --git a/packages/dev/core/src/Engines/nativeEngine.ts b/packages/dev/core/src/Engines/nativeEngine.ts
@@ -13,7 +13,7 @@ import { Tools } from "../Misc/tools";
 import type { Observer } from "../Misc/observable";
 import { Observable } from "../Misc/observable";
 import type { EnvironmentTextureSpecularInfoV1 } from "../Misc/environmentTextureTools";
-import { CreateImageDataArrayBufferViews, GetEnvInfo, UploadEnvSpherical } from "../Misc/environmentTextureTools";
+import { CreateRadianceImageDataArrayBufferViews, GetEnvInfo, UploadEnvSpherical } from "../Misc/environmentTextureTools";
 import type { Scene } from "../scene";
 import type { RenderTargetCreationOptions, TextureSize, DepthTextureCreationOptions, InternalTextureCreationOptions } from "../Materials/Textures/textureCreationOptions";
 import type { IPipelineContext } from "./IPipelineContext";
@@ -2127,7 +2127,7 @@ export class NativeEngine extends Engine {
                 }
 
                 texture._lodGenerationScale = specularInfo.lodGenerationScale;
-                const imageData = CreateImageDataArrayBufferViews(data, info);
+                const imageData = CreateRadianceImageDataArrayBufferViews(data, info);
 
                 texture.format = Constants.TEXTUREFORMAT_RGBA;
                 texture.type = Constants.TEXTURETYPE_UNSIGNED_BYTE;