Viewer: Add removeEventListener typings (#16155)

BabylonJS · Feb 6, 2025 · 9878af0 · 9878af0
1 parent dbc3d4f
commit 9878af0
Showing 1 changed file with 19 additions and 10 deletions.
diff --git a/packages/tools/viewer/src/viewerElement.ts b/packages/tools/viewer/src/viewerElement.ts
@@ -77,6 +77,25 @@ export interface ViewerElementEventMap extends HTMLElementEventMap {
     selectedmaterialvariantchange: Event;
 }
 
+// eslint-disable-next-line jsdoc/require-jsdoc
+export interface ViewerElement {
+    addEventListener<K extends keyof ViewerElementEventMap>(
+        type: K,
+        listener: (this: HTMLElement, ev: ViewerElementEventMap[K]) => any,
+        options?: boolean | AddEventListenerOptions
+    ): void;
+
+    addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
+
+    removeEventListener<K extends keyof ViewerElementEventMap>(
+        type: K,
+        listener: (this: HTMLElement, ev: ViewerElementEventMap[K]) => any,
+        options?: boolean | EventListenerOptions
+    ): void;
+
+    removeEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions): void;
+}
+
 /**
  * Base class for the viewer custom element.
  */
@@ -1033,16 +1052,6 @@ export abstract class ViewerElement<ViewerClass extends Viewer = Viewer> extends
         `;
     }
 
-    // eslint-disable-next-line babylonjs/available
-    override addEventListener<K extends keyof ViewerElementEventMap>(
-        type: K,
-        listener: (this: HTMLElement, ev: ViewerElementEventMap[K]) => any,
-        options?: boolean | AddEventListenerOptions
-    ): void;
-    override addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void {
-        super.addEventListener(type as string, listener as EventListenerOrEventListenerObject, options as boolean | AddEventListenerOptions);
-    }
-
     protected _dispatchCustomEvent<TEvent extends keyof ViewerElementEventMap>(type: TEvent, event: (type: TEvent) => ViewerElementEventMap[TEvent]) {
         this.dispatchEvent(event(type));
     }